summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJackson Taylor <jackson@jacksontaylor.xyz>2021-12-14 21:58:57 -0500
committerJackson Taylor <jackson@jacksontaylor.xyz>2022-04-05 16:52:13 -0400
commit7161387e6be222486391e75eab2bf06ef58401dd (patch)
tree43904fca5c3a987975b3fc35cf473a23693e5031
parent4e184958440dff6ad7fe9aad62eefb8d1d9020fe (diff)
Add TODOS
Mostly for install and how I want it to work in the future
-rw-r--r--README.md11
-rwxr-xr-xjamos12
2 files changed, 19 insertions, 4 deletions
diff --git a/README.md b/README.md
index 4ed66d6..01347da 100644
--- a/README.md
+++ b/README.md
@@ -3,3 +3,14 @@
## Purpose
Personal script to when downloading music with youtube-dl, tagging the files (artist, album, and track info), and organizing them into named folders.
+## Installation
+Right now, the easiest thing to do is just use it from this repo.
+
+## TODO
+ - Installation
+ - Add necessary files to install via pip
+ - AUR?
+ - Configuration
+ - Config file in XDG directory
+ - URL file in XDG directory
+ - Command line parameters
diff --git a/jamos b/jamos
index 718a698..9e6c850 100755
--- a/jamos
+++ b/jamos
@@ -27,6 +27,7 @@ AUDIO_OPTIONS = {
'writeinfojson': True
}
+# TODO: pass this instead, to make testing easier
ytdl = youtube_dl.YoutubeDL(AUDIO_OPTIONS)
@@ -61,7 +62,7 @@ def get_all_files(directory):
return files
-# TODO: Make this better with argparse
+# TODO: switch command line args to argparse
def get_playlist_url():
return sys.argv[1]
@@ -78,7 +79,9 @@ def get_video_urls_in_playlist(playlist_url):
def move_file(file, metadata):
- # TODO: Move this to its own function to have our own jamos metadata?
+ # TODO: Pass a jamos specific metadata object/dict
+ # Then we can do this validation all at once
+
artist = 'unknownartist'
album = 'unknownalbum'
title = 'unknownsong'
@@ -151,14 +154,15 @@ if __name__ == "__main__":
# Get the playlist url from the command line
playlist_url = get_playlist_url()
+ # TODO: Save urls to file so we can start in the
+ # middle of the playlist if needed
urls = get_video_urls_in_playlist(playlist_url)
for url in urls:
try:
- # TODO: make this continue downloading if a song fails
download_song(url)
except Exception as ex:
- # TODO: Handle this a different way
+ # TODO: Handle this better
print(ex)
files = get_all_files(MUSIC_DIRECTORY)